-
Notifications
You must be signed in to change notification settings - Fork 14
[OGUI-1853] Move actionables of objectTree in the table header #3247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OGUI-1853] Move actionables of objectTree in the table header #3247
Conversation
graduta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, the actionable buttons/search have not been moved to the table header, but instead at the top of the table.
Could you have a look at some ag-grid tables which offer the search input integrating in the header to provide a better UX? Somewhere under the name but in the headear of the table
While the collapse all can also be in the header most right
…ove-tree-actionables-to-table-header
…ove-tree-actionables-to-table-header
graduta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation wise, it works very well and the virtual table is once again not blocking the page.
Good job!
I left a few comments with regards to design and documentation
…ove-tree-actionables-to-table-header
I have JIRA issue created
As a user, it is difficult to see that object tree can be filtered by name. Thus, the search input text (from top right in header) should be moved in the table header in a nice UI and UX manner.
Moreover, the (collapse all tree button) should be moved also in the table header(right most).
Moreover, the sort by name buton should also become part of the header so that when the user clicks on the header Name column, to display a sort icon up, or down or nothing depending on what is currently being sorted.
See for example how Bookkeeping sorts by Title on page "Log Entries" (log-overview)